[PFA 3/n] Support PFA in const exprs#22785
Open
arnaud-lb wants to merge 3 commits into
Open
Conversation
arnaud-lb
changed the title
arnaud-lb
force-pushed
the
partials-const-expr-simple
branch
from
July 17, 2026 15:22
0ff8119 to
f5a4f79
Compare
arnaud-lb
changed the title
TimWolla
reviewed
Jul 17, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
I reviewed the PR excluding the first two commits. The tests LGTM. For the implementation, I didn't see obvious issues (except formatting nits), but I'm not fully comfortable approving the C changes.
arnaud-lb
force-pushed
the
partials-const-expr-simple
branch
from
July 20, 2026 10:08
0a6d9cd to
f153d7a
Compare
This was referenced Jul 20, 2026
arnaud-lb
marked this pull request as ready for review
July 21, 2026 12:07
… of the declaring opline itself This makes the API compatible with creating partials from AST: We can pass &ast->lineno to zend_partial_create()
Member
|
This can / should be rebased now. |
The declaring op_array is used for multiple purposes: * Generating a PFA name * Finding the filename * Finding whether op_array is cached, and therefore whether the PFA should be cached too However it's not available when evaluating a PFA AST. Remove the declaring_op_array argument, and pass the relevant information directly: * Generate the PFA name at compile time, pass it as argument to zend_partial_create() * Pass the filename and a cacheable flag as argument to zend_partial_create()
arnaud-lb
force-pushed
the
partials-const-expr-simple
branch
from
July 22, 2026 08:01
f153d7a to
9391556
Compare
Member
Author
|
I was doing it :) |
TimWolla
reviewed
Jul 22, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
Tests still LGTM. No longer seeing issues in the C implementation, but this is not my area of expertise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits. First two are GH-22783 and GH-22784, which will be merged separately. (Edit: these were merged, and the branch has been rebased.)